Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser testing #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

browser testing #15

wants to merge 2 commits into from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Mar 6, 2020 •
edited
Loading

Changes

This pull request makes the following changes:

  • adds prompt to check frontend stuff in different browsers
  • changes comment regarding appropriateness of questions to encourage people to add their own, or remove inapplicable questions
  • adds prompt for updating changelog, if applicable

Why

Because of something I did that worked in Firefox, but not Webkit

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Can this documentation be improved?

Steps to test this PR:

  1. View the diff using the "rich diff" button.

@benlk benlk requested review from joshdarby and MirandaEcho March 6, 2020 16:15
@benlk benlk self-assigned this Mar 6, 2020
@benlk benlk removed their assignment Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdarby joshdarby Awaiting requested review from joshdarby

@MirandaEcho MirandaEcho Awaiting requested review from MirandaEcho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benlk